Check for filetype only for pattern and fix coverage #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 93.12% // Head: 93.17% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
==========================================
+ Coverage 93.12% 93.17% +0.05%
==========================================
Files 47 47
Lines 2095 2096 +1
Branches 268 268
==========================================
+ Hits 1951 1953 +2
Misses 109 109
+ Partials 35 34 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sunank200
requested review from
dimberman,
tatiana,
utkarsharma2,
pankajastro,
pankajkoti and
feluelle
as code owners
kaxil
reviewed
Sep 16, 2022
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
sunank200
force-pushed
the
fix-coverage
branch
from
42e98b1
to
0038832
Compare
kaxil
approved these changes
Sep 16, 2022
kaxil
reviewed
Sep 16, 2022
kaxil
reviewed
Sep 16, 2022
kaxil
reviewed
Sep 16, 2022
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
for more information, see https://pre-commit.ci
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
for more information, see https://pre-commit.ci
utkarsharma2
pushed a commit
that referenced
this pull request
Sep 19, 2022
# Description ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Currently is filetype is passed then pattern doesn't need to be resolved to check native autodetect <!-- Issues are required for both bug fixes and features. Reference it using one of the following: closes: #ISSUE related: #ISSUE --> closes: #873 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Create file type in case not provided before checking for native autodetect schema ## Does this introduce a breaking change? No ### Checklist - [x] Created tests which fail without the change (if possible) - [x] Extended the README / documentation, if necessary Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
kaxil
added a commit
that referenced
this pull request
Sep 19, 2022
# Description ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Currently is filetype is passed then pattern doesn't need to be resolved to check native autodetect <!-- Issues are required for both bug fixes and features. Reference it using one of the following: closes: #ISSUE related: #ISSUE --> closes: #873 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Create file type in case not provided before checking for native autodetect schema ## Does this introduce a breaking change? No ### Checklist - [x] Created tests which fail without the change (if possible) - [x] Extended the README / documentation, if necessary Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
kaxil
added a commit
that referenced
this pull request
Sep 19, 2022
# Description ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Currently is filetype is passed then pattern doesn't need to be resolved to check native autodetect <!-- Issues are required for both bug fixes and features. Reference it using one of the following: closes: #ISSUE related: #ISSUE --> closes: #873 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Create file type in case not provided before checking for native autodetect schema ## Does this introduce a breaking change? No ### Checklist - [x] Created tests which fail without the change (if possible) - [x] Extended the README / documentation, if necessary Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
Currently is filetype is passed then pattern doesn't need to be resolved to check native autodetect
closes: #873
What is the new behavior?
Does this introduce a breaking change?
No
Checklist