Check for filetype instance and improve code coverage #873
Assignees
Comments
2 tasks
sunank200
added a commit
that referenced
this issue
Sep 17, 2022
# Description ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Currently is filetype is passed then pattern doesn't need to be resolved to check native autodetect <!-- Issues are required for both bug fixes and features. Reference it using one of the following: closes: #ISSUE related: #ISSUE --> closes: #873 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Create file type in case not provided before checking for native autodetect schema ## Does this introduce a breaking change? No ### Checklist - [x] Created tests which fail without the change (if possible) - [x] Extended the README / documentation, if necessary Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
utkarsharma2
pushed a commit
that referenced
this issue
Sep 19, 2022
# Description ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Currently is filetype is passed then pattern doesn't need to be resolved to check native autodetect <!-- Issues are required for both bug fixes and features. Reference it using one of the following: closes: #ISSUE related: #ISSUE --> closes: #873 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Create file type in case not provided before checking for native autodetect schema ## Does this introduce a breaking change? No ### Checklist - [x] Created tests which fail without the change (if possible) - [x] Extended the README / documentation, if necessary Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
kaxil
added a commit
that referenced
this issue
Sep 19, 2022
# Description ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Currently is filetype is passed then pattern doesn't need to be resolved to check native autodetect <!-- Issues are required for both bug fixes and features. Reference it using one of the following: closes: #ISSUE related: #ISSUE --> closes: #873 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Create file type in case not provided before checking for native autodetect schema ## Does this introduce a breaking change? No ### Checklist - [x] Created tests which fail without the change (if possible) - [x] Extended the README / documentation, if necessary Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
kaxil
added a commit
that referenced
this issue
Sep 19, 2022
# Description ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Currently is filetype is passed then pattern doesn't need to be resolved to check native autodetect <!-- Issues are required for both bug fixes and features. Reference it using one of the following: closes: #ISSUE related: #ISSUE --> closes: #873 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Create file type in case not provided before checking for native autodetect schema ## Does this introduce a breaking change? No ### Checklist - [x] Created tests which fail without the change (if possible) - [x] Extended the README / documentation, if necessary Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Currently
source_filetypein https://github.com/astronomer/astro-sdk/blob/main/python-sdk/src/astro/databases/base.py#L751 is a key value pair instead of Filetype.Expected behavior
Create file type in case not provided before checking for native autodetect schema
The text was updated successfully, but these errors were encountered: