add jestream condition check for stan component (#2090)

astronomer · Jan 24, 2024 · e7e9278 · e7e9278
1 parent 1159b5b
commit e7e9278
Show file tree

Hide file tree

Showing 8 changed files with 59 additions and 1 deletion.
diff --git a/charts/stan/templates/configmap.yaml b/charts/stan/templates/configmap.yaml
@@ -1,4 +1,7 @@
----
+##############################
+## STAN ConfigMap Template  ##
+##############################
+{{- if not .Values.global.nats.jetStream.enabled }}
 apiVersion: v1
 kind: ConfigMap
 metadata:
@@ -62,3 +65,4 @@ data:
       store_limits: {{ toPrettyJson . | indent 6 }}
       {{- end }}
     }
+{{- end }}
diff --git a/charts/stan/templates/initdb.yaml b/charts/stan/templates/initdb.yaml
@@ -1,4 +1,5 @@
 ---
+{{- if not .Values.global.nats.jetStream.enabled }}
 {{- if eq .Values.store.type "sql" }}
 {{- if .Values.store.sql.initdb.enabled }}
 apiVersion: batch/v1
@@ -46,3 +47,4 @@ spec:
      {{- end }}
 {{- end }}
 {{- end }}
+{{- end }}
diff --git a/charts/stan/templates/natsservicerole.yaml b/charts/stan/templates/natsservicerole.yaml
@@ -1,4 +1,5 @@
 ---
+{{- if not .Values.global.nats.jetStream.enabled }}
 {{- if .Values.stan.nats.serviceRoleAuth.enabled }}
 apiVersion: nats.io/v1alpha2
 kind: NatsServiceRole
@@ -20,3 +21,4 @@ kind: ServiceAccount
 metadata:
   name: nats-streaming
 {{- end }}
+{{- end }}
diff --git a/charts/stan/templates/pod-disruption-budget.yaml b/charts/stan/templates/pod-disruption-budget.yaml
@@ -1,6 +1,7 @@
 ##############################
 ## STAN Pod Disruption Budget
 ##############################
+{{- if not .Values.global.nats.jetStream.enabled }}
 {{- if .Values.global.podDisruptionBudgetsEnabled }}
 apiVersion: {{ include "apiVersion.PodDisruptionBudget" . }}
 kind: PodDisruptionBudget
@@ -14,3 +15,4 @@ spec:
       app: {{ template "stan.name" . }}
       release: {{ .Release.Name }}
 {{- end }}
+{{- end }}
diff --git a/charts/stan/templates/service.yaml b/charts/stan/templates/service.yaml
@@ -1,4 +1,8 @@
 ---
+##############################
+## STAN Service Template    ##
+##############################
+{{- if not .Values.global.nats.jetStream.enabled }}
 apiVersion: v1
 kind: Service
 metadata:
@@ -25,3 +29,4 @@ spec:
   - name: metrics
     port: 7777
     appProtocol: http
+{{- end }}
diff --git a/charts/stan/templates/stan-networkpolicy.yaml b/charts/stan/templates/stan-networkpolicy.yaml
@@ -1,6 +1,7 @@
 ################################
 ## Houston NetworkPolicy
 ################################
+{{- if not .Values.global.nats.jetStream.enabled }}
 {{- if .Values.global.networkPolicy.enabled }}
 apiVersion: networking.k8s.io/v1
 kind: NetworkPolicy
@@ -43,3 +44,4 @@ spec:
     - protocol: TCP
       port: 8222
 {{- end }}
+{{- end }}
diff --git a/charts/stan/templates/statefulset.yaml b/charts/stan/templates/statefulset.yaml
@@ -1,4 +1,8 @@
 ---
+###############################
+## STAN Statefulset Template ##
+###############################
+{{- if not .Values.global.nats.jetStream.enabled }}
 apiVersion: apps/v1
 kind: StatefulSet
 metadata:
@@ -185,3 +189,4 @@ spec:
       {{ include "stan.storageClass" . }}
   {{- end }}
   {{- end }}
+{{- end }}
diff --git a/tests/chart_tests/test_nats_jetstream.py b/tests/chart_tests/test_nats_jetstream.py
@@ -106,3 +106,39 @@ def test_nats_statefulset_with_jetstream_and_tls(self, kube_version):
             "name": "nats-jetstream-client-tls-volume",
             "secret": {"secretName": "release-name-jetstream-tls-certificate-client"},
         } in docs[10]["spec"]["template"]["spec"]["volumes"]
+
+    def test_stan_with_jetstream_enabled(self, kube_version):
+        """Test that stan statefulset is disabled when jetstream is enabled."""
+        values = {
+            "global": {"nats": {"jetStream": {"enabled": True}}},
+        }
+        docs = render_chart(
+            kube_version=kube_version,
+            values=values,
+            show_only=[
+                "charts/stan/templates/configmap.yaml",
+                "charts/stan/templates/service.yaml",
+                "charts/stan/templates/statefulset.yaml",
+                "charts/stan/templates/stan-networkpolicy.yaml",
+            ],
+        )
+
+        assert len(docs) == 0
+
+    def test_stan_with_jetstream_disabled(self, kube_version):
+        """Test that stan statefulset is disabled when jetstream is enabled."""
+        values = {
+            "global": {"nats": {"jetStream": {"enabled": False}}},
+        }
+        docs = render_chart(
+            kube_version=kube_version,
+            values=values,
+            show_only=[
+                "charts/stan/templates/configmap.yaml",
+                "charts/stan/templates/service.yaml",
+                "charts/stan/templates/statefulset.yaml",
+                "charts/stan/templates/stan-networkpolicy.yaml",
+            ],
+        )
+
+        assert len(docs) == 4