Relabeling to release for precreatednamespaces and also namespaceFreeFormEntry #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhoherd
requested changes
May 16, 2023
rujhan-arora-astronomer
changed the title
danielhoherd
requested changes
May 17, 2023
There was a problem hiding this comment.
@rujhan-arora-astronomer please pip install pre-commit and then run pre-commit install && pre-commit run --all-files from within the astronomer/astronomer repository and commit the changes.
Done! |
rujhan-arora-astronomer
force-pushed
the
4650
branch
from
7b7fa90
to
6c0bfc9
Compare
|
@danielhoherd Made some changes. Plz have a look |
rishkarajgi
approved these changes
May 18, 2023
rishkarajgi
pushed a commit
that referenced
this pull request
May 18, 2023
…FormEntry (#1887) * Relabeling to release for precreatednamespaces * Added same config to namespaceFreeFormEntry too. Also wrote tests * Added same config to namespaceFreeFormEntry too. Also wrote tests for this new template * Run pre-commit * Run pre-commit and took merge * Run pre-commit and took merge
pgvishnuram
pushed a commit
that referenced
this pull request
May 22, 2023
…FormEntry (#1887) * Relabeling to release for precreatednamespaces * Added same config to namespaceFreeFormEntry too. Also wrote tests * Added same config to namespaceFreeFormEntry too. Also wrote tests for this new template * Run pre-commit * Run pre-commit and took merge * Run pre-commit and took merge
rishkarajgi
pushed a commit
that referenced
this pull request
May 30, 2023
…1897) * Bump pre-commit, requirements (#1841) * Bump pre-commit, requirements * add tomli * Add exceptiongroup * Improve 'make clean' * Update a bunch of dev components * Allow configuring kubernetes-apiservers with insecure_skip_verify (#1881) * update vendor packages (#1885) * bump ap-grafana 8.5.22 -> 8.5.24 * bump ap-kube-state 2.7.0-1 -> 2.8.2 * bump ap-prometheus 2.37.6 -> 2.37.8 * Relabeling to release for precreatednamespaces and also namespaceFreeFormEntry (#1887) * Relabeling to release for precreatednamespaces * Added same config to namespaceFreeFormEntry too. Also wrote tests * Added same config to namespaceFreeFormEntry too. Also wrote tests for this new template * Run pre-commit * Run pre-commit and took merge * Run pre-commit and took merge * Mask sensitive data in request_uri and referrer in nginx ingress logs (#1889) * When manualNamespaceNames is enabled, attach labels the same was as done for pre-created-ns (#1892) * update images (#1879) * update nginx packages 1.23.4 -> 1.24.0 * update postgresql version 15.2.0 -> 15.2.0-1 * update scan images * update cli install and default backend service * update cli install service * include worker pods for metrics (#1895) * bump houston version for graphql subscriptions testing * elasticsearch and kibana 7.17.10 (#1896) * Update Chart.yaml Co-authored-by: Daniel Hoherd <daniel.hoherd@gmail.com> * airflow-chart 1.8.5, commander 0.32.4 (#1899) * nginx ingress controller 1.7.1 (#1900) * bump houston from 0.32.9 to 0.32.10 --------- Co-authored-by: Daniel Hoherd <daniel.hoherd@gmail.com> Co-authored-by: pgvishnuram <81585115+pgvishnuram@users.noreply.github.com> Co-authored-by: Rujhan Arora <95576577+rujhan-arora-astronomer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For pre-created namespaces pods, Relabeling and storing the release names in
releasetag, so that they can be fetched by the query made from houston, under metrics tabRelated Issues
4650
Testing
Kind cluster locally. Also, spinning up a separate cluster.
Merging
0.32.1