add service account to registry service #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielhoherd if this structure is okay i can add test cases for validating the behavior |
danielhoherd
requested changes
Jul 6, 2023
pgvishnuram
added a commit
that referenced
this pull request
Aug 21, 2023
* add service account to registry service * add service account template * update registry service account configuration * cleanup values * disable sa creation by default * update base test cases for registry sa * fix pre-commit * update registry test cases * update valid spec path * fix test cases * test case complete
pgvishnuram
added a commit
that referenced
this pull request
Aug 21, 2023
* add service account to registry service * add service account template * update registry service account configuration * cleanup values * disable sa creation by default * update base test cases for registry sa * fix pre-commit * update registry test cases * update valid spec path * fix test cases * test case complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Registry is by default configured to use default serviceAccount , this changes allows user to enable serviceAccount to be added either with custom name or default name. This allows user to make use of IRSA and GKE Managed Identity.
Related Issues
https://github.com/astronomer/issues/issues/5692
Testing
Do not merge this PR until this text is replaced with details about how these changes were tested.
Merging
Do not merge this PR until it lists which release branches this PR should be merged / cherry-picked into.