Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Prisma Cloud Docker Image Scans #1947

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Conversation

mishah334
Copy link
Contributor

@mishah334 mishah334 commented Aug 4, 2023

Description

Adding integration of Prisma Cloud Docker Image Scans using twistcli.

Related Issues

N/A

Testing

This change was tested directly by calling the Circleci job.

Example: https://app.circleci.com/pipelines/github/astronomer/astronomer/9133/workflows/91275c9f-c0c4-4ebb-8b34-6ddb354196b3

Merging

All active releases.

@mishah334 mishah334 requested a review from a team as a code owner August 4, 2023 10:26
@vishwas-astro
Copy link
Contributor

Mishal, isn't twistcli from Prisma and not Prima?

Also, was this change initiated by Zac and his security team (Ryan restivo and Victor Lucas)?

Copy link
Contributor

@rishkarajgi rishkarajgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit and tests failing

@mishah334
Copy link
Contributor Author

Prisma

Yes, it is Prisma, Sorry for the typo. Victor Lucas suggested this practice. We connected last week to discuss the Prisma Cloud.

@mishah334
Copy link
Contributor Author

pre-commit and tests failing

Mergingmaster branch made it fail because of the updated image. Added a fix.

@mishah334 mishah334 changed the title Integrate Prima Cloud Docker Image Scans Integrate Prisma Cloud Docker Image Scans Aug 8, 2023
@mishah334 mishah334 merged commit 7b06fdf into master Aug 8, 2023
7 of 9 checks passed
@mishah334 mishah334 deleted the integrate-prima-scans branch August 8, 2023 14:21
danielhoherd pushed a commit that referenced this pull request Feb 6, 2024
* Adding support of twistcli docker scans.

* Adding curl.

* Printing details after scan.

* Applying master changes.

---------

Co-authored-by: Rishabh Karajgi <rishabh.karajgi@gmail.com>
danielhoherd pushed a commit that referenced this pull request Feb 6, 2024
* Adding support of twistcli docker scans.

* Adding curl.

* Printing details after scan.

* Applying master changes.

---------

Co-authored-by: Rishabh Karajgi <rishabh.karajgi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants