Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logging flag in stan config #1975

Merged
merged 4 commits into from
Oct 10, 2023
Merged

fix logging flag in stan config #1975

merged 4 commits into from
Oct 10, 2023

Conversation

pgvishnuram
Copy link
Contributor

@pgvishnuram pgvishnuram commented Sep 4, 2023

Description

Fix log toggling behaviour

Related Issues

https://github.com/astronomer/issues/issues/5796

Testing

QA should able to switch the logging config as per the need

Merging

cherry-pick to all supported branches

@pgvishnuram pgvishnuram marked this pull request as ready for review September 4, 2023 07:06
@pgvishnuram pgvishnuram requested a review from a team as a code owner September 4, 2023 07:06
Copy link
Member

@danielhoherd danielhoherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. We need to add tests though. For instance we need to check for the presence and absence of sd: true and sv: true when helm is given different values.

@pgvishnuram pgvishnuram merged commit a088980 into master Oct 10, 2023
12 checks passed
@pgvishnuram pgvishnuram deleted the improve-stan-config branch October 10, 2023 15:22
pgvishnuram added a commit that referenced this pull request Oct 11, 2023
* fix logging flag in stan config

* add test cases for stan logging toggle flag

---------

Co-authored-by: Daniel Hoherd <daniel.hoherd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants