Enforce k8s version constraints #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgvishnuram
reviewed
Sep 14, 2023
pgvishnuram
approved these changes
Sep 14, 2023
danielhoherd
added a commit
that referenced
this pull request
Sep 14, 2023
* Put k8s version constraints into helm. * Remove GitPython * Use metadata.yaml in pytest and circleci. Add tests. * add validate_objects arg to render_chart() * Add tests * Do not allow releasing to internal from non-release branches --------- Co-authored-by: pgvishnuram <81585115+pgvishnuram@users.noreply.github.com>
danielhoherd
added a commit
that referenced
this pull request
Sep 14, 2023
* Put k8s version constraints into helm. * Remove GitPython * Use metadata.yaml in pytest and circleci. Add tests. * add validate_objects arg to render_chart() * Add tests * Do not allow releasing to internal from non-release branches --------- Co-authored-by: pgvishnuram <81585115+pgvishnuram@users.noreply.github.com>
danielhoherd
added a commit
that referenced
this pull request
Sep 14, 2023
* Put k8s version constraints into helm. * Remove GitPython * Use metadata.yaml in pytest and circleci. Add tests. * add validate_objects arg to render_chart() * Add tests * Do not allow releasing to internal from non-release branches --------- Co-authored-by: pgvishnuram <81585115+pgvishnuram@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
metadata.yamlfile that holds the single source of truth of which versions of k8s are supported. This file should be used for other cases where having a single source of data that is not specific to helm is needed.validate_objectsarg torender_chart(). This is required when we support the latest k8s version available because the schema files of the next version would not yet be available to validate. This also avoids caching schema files in the repo for versions that we do not support.Related Issues
https://github.com/astronomer/issues/issues/5824
See the above ticket for a link to relevant slack discussion about why this change is needed.
Testing
I think I have covered all cases with unit tests. QA should be on the lookout for helm errors that indicate that the version is too new or old. These errors will be obvious because helm will fail and not install the chart.
Merging
This change set needs to be merged to all supported branches.