Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nats jetstream support #2000

Merged
merged 40 commits into from
Jan 9, 2024
Merged

Enable nats jetstream support #2000

merged 40 commits into from
Jan 9, 2024

Conversation

pgvishnuram
Copy link
Contributor

@pgvishnuram pgvishnuram commented Sep 22, 2023

Description

This PR adds support for nats + jetsteam configuration and other inter config changes between components

Related Issues

astronomer/issues#5926

Testing

Updated in ticket

Merging

cherry-pick to release-0.34

@pgvishnuram pgvishnuram changed the title add nats jetstream support Enable nats jetstream support Oct 17, 2023
pgvishnuram and others added 2 commits December 20, 2023 23:11
Co-authored-by: Daniel Hoherd <daniel.hoherd@gmail.com>
Co-authored-by: Daniel Hoherd <daniel.hoherd@gmail.com>
## Nats Jetstream SSL Certificate ##
######################################
{{ if and .Values.global.nats.jetStream.enabled .Values.global.nats.jetStream.tls }}
{{- $ca := genCA "ca" 3650 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dude, this genCA function led me to this, which I think can vastly simplify all of this certificate stuff: https://helm.sh/docs/chart_template_guide/function_list/#cryptographic-and-security-functions

EG:

$cert := genSelfSignedCert "foo.com" (list "10.0.0.1" "10.0.0.2") (list "bar.com" "bat.com") 365

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reworking the changes - i was previously using this function but wasnt using right config to make services up - will alter the changes reduce the code in here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reworked the changes and removed the custom script

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielhoherd this job template should in common template so that i can use the hash to restart houston and houston-worker if it requires a restart due to this change - currently worker may not get restart if there is change in certs

@pgvishnuram pgvishnuram marked this pull request as ready for review December 22, 2023 11:50
@pgvishnuram pgvishnuram requested a review from a team as a code owner December 22, 2023 11:50
@pgvishnuram pgvishnuram merged commit a574511 into master Jan 9, 2024
7 of 8 checks passed
@pgvishnuram pgvishnuram deleted the upgrade-nats-service branch January 9, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants