segregate kibana index network policy #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| port: {{ .Values.ports.http }} | ||
| {{- end}} | ||
| {{ if .Values.createDefaultIndex }} | ||
| - from: |
There was a problem hiding this comment.
Is this correct? We're adding a completely new from block to go along with the old one?
There was a problem hiding this comment.
The old block was:
ingress:
- from:
- podSelector:
matchLabels:
tier: nginx
component: ingress-controller
release: release-name
- podSelector:
matchLabels:
component: kibana-default-index
release: release-name
tier: logging
ports:
- protocol: TCP
port: 5601The new block is
ingress:
- from:
- podSelector:
matchLabels:
tier: nginx
component: ingress-controller
release: release-name
ports:
- protocol: TCP
port: 5601
- from:
- podSelector:
matchLabels:
component: kibana-default-index
release: release-name
tier: logging
ports:
- protocol: TCP
port: 5601Is that correct?
There was a problem hiding this comment.
I wanted to add a new from: when createDefaultIndex is enabled
There was a problem hiding this comment.
There was a problem hiding this comment.
with current code without authsidecar
ingress:
- from:
- podSelector:
matchLabels:
tier: nginx
component: ingress-controller
release: astronomer
- podSelector:
matchLabels:
component: kibana-default-index
release: astronomer
tier: logging
ports:
- protocol: TCP
port: 5601
with current code with authsidecar it will fail since the port is using 8084 and requires houston authorization
ingress:
- from:
- namespaceSelector:
matchLabels:
network.openshift.io/policy-group: ingress
- podSelector:
matchLabels:
component: kibana-default-index
release: astronomer
tier: logging
ports:
- protocol: TCP
port: 8084
There was a problem hiding this comment.
our new logic is to segregate the ingress and put a seperate rule to handle that case
pgvishnuram
added a commit
that referenced
this pull request
Oct 13, 2023
* segregate kibana index network policy * update network policy for kibana index pattern * fix kibana policy tests * fix authsidecar tests
pgvishnuram
added a commit
that referenced
this pull request
Oct 18, 2023
* segregate kibana index network policy * update network policy for kibana index pattern * fix kibana policy tests * fix authsidecar tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add seperate network policy within kibana network policy template this fixes an odd behaviour when authsidecar is enabled
Related Issues
https://github.com/astronomer/issues/issues/5912
Testing
QA should able to validate kibana index pattern creation with authsidecar enabled
Merging
cherry-pick to release-0.33