Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make cli-install feature optional #2072

Merged
merged 7 commits into from
Dec 5, 2023
Merged

make cli-install feature optional #2072

merged 7 commits into from
Dec 5, 2023

Conversation

pgvishnuram
Copy link
Contributor

@pgvishnuram pgvishnuram commented Dec 1, 2023 •
edited

Description

make cli install service optionable

Related Issues

https://github.com/astronomer/issues/issues/6015

Testing

Yet to update

Merging

Yet to update

@danielhoherd danielhoherd changed the title 6015 make cli install service optionable 6015 make cli install service optional Dec 4, 2023
@pgvishnuram pgvishnuram marked this pull request as ready for review December 5, 2023 04:41
@pgvishnuram pgvishnuram requested a review from a team as a code owner December 5, 2023 04:41
rishkarajgi
rishkarajgi reviewed Dec 5, 2023
View reviewed changes
charts/astronomer/values.yaml Outdated
@@ -423,6 +423,7 @@ registry:
logLevel: info

install:
enabled: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.Values.install.enabled is not conveying the reference to CLI
We should rename the flag to cliEnabled for better clarity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might affect existing deployment config since customers are using this for a long time we can add both configs and we can state that old config will be removed in 0.34

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree with @rishkarajgi that having cliInstall would have been better, but i also agree with @pgvishnuram that changing the parent namespace of the new enabled parameter is outside of the scope of this ticket and could introduce problems. if we want to improve the install value namespace, we should do that on a minor version bump and address that in another ticket.

danielhoherd
danielhoherd approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@danielhoherd danielhoherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me. If we want to address the install -> cliInstall change, we should open another ticket and schedule that work.

@danielhoherd danielhoherd merged commit 3e1468b into master Dec 5, 2023
7 of 8 checks passed
@danielhoherd danielhoherd deleted the 6015-make-cli-install-service-optionable branch December 5, 2023 14:32
@danielhoherd danielhoherd changed the title 6015 make cli install service optional make cli-install feature optional Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhoherd danielhoherd danielhoherd approved these changes

@rishkarajgi rishkarajgi Awaiting requested review from rishkarajgi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pgvishnuram @danielhoherd @rishkarajgi