add custom ca volume on right indent #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishkarajgi
approved these changes
Jan 25, 2024
|
Tests failing on platform-1-28-0 and platform-1-24-15 |
|
tests has passed merging to master and release-0.34 branch |
pgvishnuram
added a commit
that referenced
this pull request
Jan 25, 2024
* add custom ca volume on right indent * updated registry ca private * fix registry tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes an issue where private ca added in wrong indent causing registry deployment not exposing ca-volumes causing deployments to not able to patch
Related Issues
https://github.com/astronomer/issues/issues/5939
Testing
QA should able to see CA certs when registry type is deployment
Merging
cherry-pick to release-0.34