Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix containerd host config path #2093

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Conversation

pgvishnuram
Copy link
Contributor

@pgvishnuram pgvishnuram commented Jan 30, 2024

Description

  • optimize the script
  • remove containerd daemon restart when containerd config has config_path set
  • remove unnecessary code

Related Issues

https://github.com/astronomer/issues/issues/6022
https://github.com/astronomer/issues/issues/6116

Testing

updated on issue ticket

Merging

cherry-pick to release-0.34

@pgvishnuram pgvishnuram marked this pull request as ready for review January 30, 2024 20:00
@pgvishnuram pgvishnuram requested a review from a team as a code owner January 30, 2024 20:00
@pgvishnuram pgvishnuram merged commit e1e2c23 into master Jan 31, 2024
6 of 8 checks passed
@pgvishnuram pgvishnuram deleted the enhance-containerd-config branch January 31, 2024 07:01
pgvishnuram added a commit that referenced this pull request Jan 31, 2024
* fix containerd host config path

* update containerd config script

* remove unused code

* skip containerd restart when config_path is enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants