add dagOnlyDeployment feature flag in astronomer helm chart #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishkarajgi
reviewed
Jan 31, 2024
rishkarajgi
changed the title
danielhoherd
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
LGTM. I made one commit with some slight test case improvements. c8e4823
pgvishnuram
added a commit
that referenced
this pull request
Jan 31, 2024
* add dagonlydeployment feature in astronomer * add houston config flag for dagDeployment * update test case for dag only deploy feature * fix wrong config location * fix indent * fix comments * Use reusable data. Use obvious test data. --------- Co-authored-by: Daniel Hoherd <daniel.hoherd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
https://github.com/astronomer/issues/issues/5969
https://github.com/astronomer/issues/issues/5975
Testing
unit tests are included, but we'll need testing from QA.
Merging
This is only for release-0.34