Add out of box private registry support for dag deploy #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhoherd
approved these changes
Feb 2, 2024
pgvishnuram
added a commit
that referenced
this pull request
Feb 2, 2024
* fix pre-commit * add tests for dagdeploy private registry * fix ci failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add out of box private registry support for dag deploy
Related Issues
Do not merge this PR until this text is replaced with links to related issues.
Testing
QA should able to enable private and does not require to modify image for dag server
Merging
cherry-pick to release-0.34