-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace cert copier image #2116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhoherd
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Using templates for image:tag is so clean. I like this pattern we've been using lately. I also like the addition of this image to enable_all_features.yaml. Tests are failing, but once they are passing I say Shipit!
rishkarajgi
approved these changes
Feb 7, 2024
danielhoherd
approved these changes
Feb 7, 2024
pgvishnuram
added a commit
that referenced
this pull request
Feb 7, 2024
* fix pre-commit * fix hardcoded imagePullPolicy * fix naming * add app labels * add version tag in daemonset * fix pre-commit
pgvishnuram
added a commit
that referenced
this pull request
Feb 14, 2024
* fix pre-commit * fix hardcoded imagePullPolicy * fix naming * add app labels * add version tag in daemonset * fix pre-commit
pgvishnuram
added a commit
that referenced
this pull request
Feb 14, 2024
pgvishnuram
added a commit
that referenced
this pull request
Feb 19, 2024
* fix pre-commit * fix hardcoded imagePullPolicy * fix naming * add app labels * add version tag in daemonset * fix pre-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
move cert copier image alpine:3.18 to astronomer managed quay repo
alpine:3.18 -> quay.io/astronomer/ap-base:3.18
Related Issues
https://github.com/astronomer/issues/issues/6102
Testing
when global private registry it should auto switch to private registry
Merging
cherry-pick to all valid branches