Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cert copier image #2116

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Replace cert copier image #2116

merged 6 commits into from
Feb 7, 2024

Conversation

pgvishnuram
Copy link
Contributor

@pgvishnuram pgvishnuram commented Feb 7, 2024

Description

move cert copier image alpine:3.18 to astronomer managed quay repo
alpine:3.18 -> quay.io/astronomer/ap-base:3.18

Related Issues

https://github.com/astronomer/issues/issues/6102

Testing

when global private registry it should auto switch to private registry

Merging

cherry-pick to all valid branches

Copy link
Member

@danielhoherd danielhoherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Using templates for image:tag is so clean. I like this pattern we've been using lately. I also like the addition of this image to enable_all_features.yaml. Tests are failing, but once they are passing I say Shipit!

@pgvishnuram pgvishnuram marked this pull request as ready for review February 7, 2024 14:56
@pgvishnuram pgvishnuram requested a review from a team as a code owner February 7, 2024 14:56
@pgvishnuram pgvishnuram merged commit 193da85 into master Feb 7, 2024
7 of 8 checks passed
@pgvishnuram pgvishnuram deleted the replace-cert-copier-image branch February 7, 2024 16:56
pgvishnuram added a commit that referenced this pull request Feb 7, 2024
* fix pre-commit

* fix hardcoded imagePullPolicy

* fix naming

* add app labels

* add version tag in daemonset

* fix pre-commit
pgvishnuram added a commit that referenced this pull request Feb 14, 2024
* fix pre-commit

* fix hardcoded imagePullPolicy

* fix naming

* add app labels

* add version tag in daemonset

* fix pre-commit
pgvishnuram added a commit that referenced this pull request Feb 14, 2024
* fix pre-commit

* fix hardcoded imagePullPolicy

* fix naming

* add app labels

* add version tag in daemonset

* fix pre-commit
pgvishnuram added a commit that referenced this pull request Feb 19, 2024
* fix pre-commit

* fix hardcoded imagePullPolicy

* fix naming

* add app labels

* add version tag in daemonset

* fix pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants