Make houston-db-migrations run both pre-upgrade and post-upgrade helm hooks #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhoherd
changed the title
danielhoherd
changed the title
pgvishnuram
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Workaround to an order-of-operations bug that we discovered. More details in the issue linked below.
Related Issues
https://github.com/astronomer/issues/issues/6152
Testing
This solves a problem where houston requires deploys to happen twice before picking up the AU vs resources configuration setting.
Merging
AFAIK this would only be needed in release-0.34, but the root cause may be happening elsewhere and we haven't noticed.