segregate resource strategy Migration Job #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishkarajgi
reviewed
Feb 9, 2024
| @@ -14,7 +14,7 @@ metadata: | |||
| annotations: | |||
| # This is what defines this resource as a hook. Without this line, the | |||
| # job is considered part of the release. | |||
| "helm.sh/hook": pre-upgrade,post-upgrade,post-install | |||
| "helm.sh/hook": pre-upgrade,post-install | |||
There was a problem hiding this comment.
the annotation is different here https://github.com/astronomer/astronomer/pull/2123/files
There was a problem hiding this comment.
https://github.com/astronomer/astronomer/blob/v0.33.3/charts/astronomer/templates/houston/helm-hooks/houston-db-migration-job.yaml#L17 - this is the original annotations
There was a problem hiding this comment.
this job is going to run after the upgrade as a seperate job and we are removing the annotation not to run on houston upgrade
rishkarajgi
approved these changes
Feb 9, 2024
danielhoherd
changed the title
rishkarajgi
pushed a commit
that referenced
this pull request
Feb 9, 2024
* fix pre-commit * update migration job * add test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
segregate resource Strategy Migration Job
Related Issues
https://github.com/astronomer/issues/issues/6152
Testing
Yet to update
Merging
Yet to update