Add check for Calico CRDs for each tested k8s version #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgvishnuram
approved these changes
Mar 28, 2024
danielhoherd
added a commit
that referenced
this pull request
Mar 28, 2024
danielhoherd
added a commit
that referenced
this pull request
Mar 28, 2024
danielhoherd
added a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abort
bin/generate_circleci_config.pyif Calico CRDs are not found for k8s versions that are being added to.circleci/config.yml. This has bitten us before, and it's not a huge deal, but it is wasteful and time consuming to have to go through that iteration.I canceled CI because no CI-facing code changed. This is strictly a developer local-workstation change.
Related Issues
https://github.com/astronomer/issues/issues/6240
Testing
This is strictly a dev workflow improvement, not customer facing, and does not change the shipped product in any way, so no QA is needed.
Merging
Merge everywhere.