remove duplicate annotation in nats statefulset #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
combined config from two metadata.annotations
pgvishnuram
changed the title
pgvishnuram
reviewed
Apr 8, 2024
Comment on lines
24
to
+29
| metadata: | ||
| {{- if or .Values.podAnnotations .Values.exporter.enabled }} | ||
| annotations: | ||
| checksum/nats-config: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }} | ||
| {{- if and .Values.global.nats.jetStream.enabled .Values.global.nats.jetStream.tls }} | ||
| checksum/nats-tls: {{ include (print $.Template.BasePath "/nats-jetstream-tls-secret.yaml") . | sha256sum }} | ||
| {{- end }} |
There was a problem hiding this comment.
@danielhoherd this is a new change on top of sudharsan change
rishkarajgi
approved these changes
Apr 8, 2024
|
Tests are failing |
|
Let me re-run them , adding basic test case for annotation validation |
|
Can we explicitly test the upgrade path here I am expecting it to result in failures and that variable being completely unset for a period of time between the two due to helm issue 10741. What would the impact to the platform be during that time? |
|
i dont think this will cause an issue for the customers |
rishkarajgi
added a commit
that referenced
this pull request
Apr 8, 2024
* Update statefulset.yaml combined config from two metadata.annotations * update nats statefulset annotation work * add basic annotation tests * add key assertion * fix pre-commit * fix test failures --------- Co-authored-by: pgvishnuram <vishnu@astronomer.io> Co-authored-by: Rishabh Karajgi <rishabh.karajgi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combined config from two metadata.annotations
Description
There are two annotation sections in the NATS statefulsets,
Related Issues
fixes: https://github.com/astronomer/issues/issues/6284
Testing
Do not merge this PR until this text is replaced with details about how these changes were tested.
Merging
Do not merge this PR until it lists which release branches this PR should be merged / cherry-picked into.