-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Airflow examples docs #39
Conversation
I'll defer to @schnie, however:
|
+1 for Airflow Core. My preference is Airflow Suite, Airflow Bundle or Airflow Stack for "Enterprise" bundle. |
We should also consider the branding Astronomer Core, Astronomer [Bundle, Suite, Stack]. |
Core seems fine for the slim version. I kind of like keeping enterprise though. |
Cool - I just pushed an update renaming all references of Airflow Lite to Airflow Core; no change to Airflow Enterprise name for now. Are we good to merge this? |
Andy talked with a customer today who was confused that the Airflow Enterprise example is not Astronomer Enterprise (#44). It's not the same reason we made this issue/PR but it is the same topic we've been discussing here. @schnie Any more thoughts on what we should do here? Andy has another suggestion in the linked issue as well. @andscoop's suggestion in #44 was |
LGTM - this PR adds some clarity that didn't exist before. We can revisit naming issue if it continues to be a problem |
Add instructions to start Airflow examples and make comparison clear between Lite vs Enterprise examples.
Here's how it looks now:
Side note: I think we should consider a clearer naming convention for the examples. (Lite sounds like it's not full featured Airflow; Enterprise makes sense as an approximation of EE but maybe another name could convey that better.)
Some suggestions for Airflow Lite from discussion with Andy & Ben are:
For Airflow Enterprise:
@schnie @andscoop @ryw Thoughts?
And also - does it make sense to add the CLI to the comparison table for EE?