Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Airflow examples docs #39

Merged
merged 6 commits into from
Apr 14, 2018
Merged

Update Airflow examples docs #39

merged 6 commits into from
Apr 14, 2018

Conversation

tedmiston
Copy link
Contributor

@tedmiston tedmiston commented Mar 17, 2018

Add instructions to start Airflow examples and make comparison clear between Lite vs Enterprise examples.

Here's how it looks now:

screen shot 2018-03-16 at 7 42 44 pm

Side note: I think we should consider a clearer naming convention for the examples. (Lite sounds like it's not full featured Airflow; Enterprise makes sense as an approximation of EE but maybe another name could convey that better.)

Some suggestions for Airflow Lite from discussion with Andy & Ben are:

  • Airflow Core
  • Airflow Base
  • Airflow (Simple)

For Airflow Enterprise:

  • Airflow Suite
  • Airflow Plus Plus
  • Airflow (Fancy)

@schnie @andscoop @ryw Thoughts?

And also - does it make sense to add the CLI to the comparison table for EE?

@tedmiston tedmiston added this to the 4/11/18 milestone Mar 17, 2018
@ryw ryw requested a review from schnie March 18, 2018 14:17
@ryw ryw removed their assignment Mar 18, 2018
@ryw
Copy link
Contributor

ryw commented Mar 18, 2018

I'll defer to @schnie, however:

  • i like "Airflow Core" and "Airflow w/ Monitoring"
  • cli isn't part of open, so shouldn't be part of this chart, if we're simply comparing the examples, and i don't think we should add marketing for astronomer enterprise in the open docs

@andscoop
Copy link
Contributor

+1 for Airflow Core.

My preference is Airflow Suite, Airflow Bundle or Airflow Stack for "Enterprise" bundle.

@andscoop
Copy link
Contributor

We should also consider the branding Astronomer Core, Astronomer [Bundle, Suite, Stack].

@schnie
Copy link
Member

schnie commented Mar 19, 2018

Core seems fine for the slim version. I kind of like keeping enterprise though.

@tedmiston
Copy link
Contributor Author

Cool - I just pushed an update renaming all references of Airflow Lite to Airflow Core; no change to Airflow Enterprise name for now.

Are we good to merge this?

@andscoop andscoop mentioned this pull request Mar 22, 2018
@tedmiston
Copy link
Contributor Author

tedmiston commented Mar 22, 2018

Andy talked with a customer today who was confused that the Airflow Enterprise example is not Astronomer Enterprise (#44). It's not the same reason we made this issue/PR but it is the same topic we've been discussing here.

@schnie Any more thoughts on what we should do here? Andy has another suggestion in the linked issue as well.

@andscoop's suggestion in #44 was airflow-enterpriseairflow-ee-bundle

@andscoop andscoop merged commit 32ff48b into master Apr 14, 2018
@andscoop
Copy link
Contributor

LGTM - this PR adds some clarity that didn't exist before. We can revisit naming issue if it continues to be a problem

@tedmiston tedmiston deleted the airflow-examples-docs branch April 17, 2018 16:38
schnie pushed a commit that referenced this pull request Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants