Skip to content

Commit

Permalink
Merge pull request #213 from astronomy-commons/sean/fix-soap-catalog-…
Browse files Browse the repository at this point in the history
…info

Fix soap arguments to catalog info not including all parameters
  • Loading branch information
smcguire-cmu committed Feb 16, 2024
2 parents d36a212 + 3b5a29c commit dd63dfe
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/hipscat_import/soap/arguments.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ def to_catalog_info(self, total_rows) -> AssociationCatalogInfo:
"primary_catalog": str(self.object_catalog_dir),
"join_column": self.source_object_id_column,
"join_catalog": str(self.source_catalog_dir),
"contains_leaf_files": self.write_leaf_files,
}
return AssociationCatalogInfo(**info)

Expand Down
2 changes: 2 additions & 0 deletions tests/hipscat_import/soap/test_run_soap.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ def test_object_to_source(dask_client, small_sky_soap_args):
assert catalog.catalog_path == small_sky_soap_args.catalog_path
assert len(catalog.get_join_pixels()) == 14
assert catalog.catalog_info.total_rows == 17161
assert not catalog.catalog_info.contains_leaf_files


@pytest.mark.dask
Expand Down Expand Up @@ -58,3 +59,4 @@ def test_object_to_source_with_leaves(
assert catalog.catalog_path == small_sky_soap_args.catalog_path
assert len(catalog.get_join_pixels()) == 14
assert catalog.catalog_info.total_rows == 17161
assert catalog.catalog_info.contains_leaf_files

0 comments on commit dd63dfe

Please sign in to comment.