Set lower default import order. #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1022 1022
=========================================
Hits 1022 1022
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I don't have enough hands on context, but will users have a good intuition about when to change this default value? And how to experiment with different values? |
delucchi-cmu
added a commit
that referenced
this pull request
Nov 6, 2023
* Set lower default import order. (#153) * Macauff pipeline boilerplate (#152) * checkpoint * checkpoint * testing for MacauffArguments * create boilerplate for macauff runner + tests * remove commented out test * add __future__.annotations * linter problems * add more tests for missing coverage * refactor MacauffArguments required parameter tests * address more comments from pr #152 * add dask pytest mark + black formatting * Add a partition_info on SOAP results. (#157) * Initial commit of metadata file conversion (#156) * Initial commit of metadata file conversion * Move shared logic for locating input files. * Explicitly depend on pyyaml --------- Co-authored-by: Max West <110124344+maxwest-uw@users.noreply.github.com>
delucchi-cmu
added a commit
that referenced
this pull request
Nov 6, 2023
* Use existing hipscat_index for mapping pixel * Update required version. * Merge recent changes (#163) * Set lower default import order. (#153) * Macauff pipeline boilerplate (#152) * checkpoint * checkpoint * testing for MacauffArguments * create boilerplate for macauff runner + tests * remove commented out test * add __future__.annotations * linter problems * add more tests for missing coverage * refactor MacauffArguments required parameter tests * address more comments from pr #152 * add dask pytest mark + black formatting * Add a partition_info on SOAP results. (#157) * Initial commit of metadata file conversion (#156) * Initial commit of metadata file conversion * Move shared logic for locating input files. * Explicitly depend on pyyaml --------- Co-authored-by: Max West <110124344+maxwest-uw@users.noreply.github.com> * Exercise more hipscat_index behavior. --------- Co-authored-by: Max West <110124344+maxwest-uw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the default
highest_healpix_orderparameter lower. This reduces the intermediate storage, and speeds most operations. For importing larger, denser catalogs, this will need to be overridden to a larger value, but for the majority of catalogs right now, 7 is sufficient.