Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use type-specific catalog info #84

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Use type-specific catalog info #84

merged 3 commits into from
Jun 14, 2023

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Create catalog-type-specific metadata in the resulting catalog_info.json file.

Solution Description

Uses the new subclasses defined in astronomy-commons/hipscat#101 , and requires hipscat v0.0.12

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have added unit/End-to-End (E2E) test cases to cover my new feature

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #84 (2eaf08b) into main (cdf887d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files          23       23           
  Lines         855      863    +8     
=======================================
+ Hits          851      859    +8     
  Misses          4        4           
Impacted Files Coverage Δ
src/hipscat_import/association/arguments.py 100.00% <100.00%> (ø)
src/hipscat_import/association/run_association.py 100.00% <100.00%> (ø)
src/hipscat_import/catalog/arguments.py 100.00% <100.00%> (ø)
src/hipscat_import/catalog/run_import.py 100.00% <100.00%> (ø)
src/hipscat_import/index/arguments.py 100.00% <100.00%> (ø)
src/hipscat_import/index/run_index.py 100.00% <100.00%> (ø)
...scat_import/margin_cache/margin_cache_arguments.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@delucchi-cmu delucchi-cmu merged commit c2d0570 into main Jun 14, 2023
13 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/catalog_info branch June 30, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants