Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for example in documentation. #92

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

In PR #91 , I claim that you can handle not-previously-seen-file-types with arguments like

        input_format="starr",
        file_reader=StarrReader(),

This is how I convinced myself that was true, and will prevent regression for documented behavior.

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #92 (5c3655c) into main (f0cd4bf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #92   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          805       805           
=========================================
  Hits           805       805           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@delucchi-cmu delucchi-cmu requested review from a team and dougbrn and removed request for a team June 22, 2023 16:00
Copy link

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@delucchi-cmu delucchi-cmu merged commit 1a27d41 into main Jun 22, 2023
13 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/starr branch June 30, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants