adding functionality to set labels #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le issues that are closed (astropy#54)
|
@bsipocz do you want to have a look before I merge? @astrofrog are you still awake? If I don't hear by 6PM, I'll just merge as is. This LGTM. Thanks! |
pllim
approved these changes
May 3, 2018
|
@pllim - Let's merge :) |
|
Thanks @dr-rodriguez and @pllim! |
|
Huh... I can see the "close and comment" button but I cannot see "merge". |
|
Oh, it is merged already. Thanks, @bsipocz . Hahaha... |
astrofrog
pushed a commit
to OpenAstronomy/baldrick
that referenced
this pull request
Jul 19, 2018
adding functionality to set labels
astrofrog
pushed a commit
to OpenAstronomy/baldrick
that referenced
this pull request
Jul 19, 2018
adding functionality to set labels
astrofrog
pushed a commit
to OpenAstronomy/baldrick
that referenced
this pull request
Jul 23, 2018
adding functionality to set labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some additional methods to IssueHandler to allow for labels to be set (#54). Also added a line in stale issues to add the 'closed-by-bot' label on issues that are auto-closed.
Also relevant to issues #65 and #66
Tests are still needed for the new method.