Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spectrumplot tutorial data cube to astropy-data #86

Closed
wants to merge 1 commit into from
Closed

Add spectrumplot tutorial data cube to astropy-data #86

wants to merge 1 commit into from

Conversation

kakirastern
Copy link
Contributor

For the spectrumplottutorial to be added to Learn Astropy. The most important content here is the data cube fits file.

@bsipocz
Copy link
Member

bsipocz commented Feb 26, 2020

@kakirastern - I think only the fits file should end up in this reposity from this PR. Both the scripts and rst docs should live in the tutorials repo. Same for the image, or in fact best would be to not even store the image but generate on the spot.

@kakirastern
Copy link
Contributor Author

Hi @bsipocz Agreed. Have removed all files except the FITS file for the data cube to be used in the spectrumplot tutorial in this PR.

@bsipocz
Copy link
Member

bsipocz commented Feb 26, 2020

Thanks for the quick follow-up.

I would like to see the review for the tutorial itself, in astropy/astropy-tutorials#423, before merging the file into this repo.

Also, it doesn't have to be now, but squashing the two commits is favourable to keep the unrelated files out of the history.

Make changes as per reviewer's suggestion
@kakirastern
Copy link
Contributor Author

Not a problem! Have just squashed the commits into one before I forget. I will probably get back to this PR once the PR astropy/astropy-tutorials#423 has been reviewed.

@bsipocz
Copy link
Member

bsipocz commented Feb 26, 2020

Thanks. Basically the main thing I need from that review that this is the ideal file for the purposes of the tutorial (and/or possible reuses for future tutorials)

@kakirastern
Copy link
Contributor Author

kakirastern commented Feb 26, 2020

Sure, will be careful to let the repo maintainers know. They are indeed aware that I have been working on the tutorial even though no review for it has been made yet.

@kakirastern kakirastern changed the title Add spectrumplot tutorial files to astropy-data Add spectrumplot tutorial data cube to astropy-data Mar 21, 2020
@kakirastern
Copy link
Contributor Author

kakirastern commented Aug 28, 2020

Apologies for the delay, but we have had some protracted discussions regarding where to store the concerned data file for a new Learn Astropy tutorial for the past few weeks. As a decision has been reached in last week's Learn Astropy meeting, I will follow up on this soon after updating the code in the tutorial notebook to download the temporary link instead.

@eteq
Copy link
Member

eteq commented Dec 15, 2020

closed at request of the author - last SHA 216305a

@eteq eteq closed this Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants