-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Spectrum Plot" tutorial to Learn Astropy repo #423
Conversation
May need to add |
Am testing the setup tonight but unfortunately is not in form so kept making minor mistakes... Once the PR passes the CircleCI tests will then rebase and squash all commits into one. |
My apologies for the many CircleCI failures. This tutorial works locally but for some reason needs much effort to get it to work on Learn Astropy as well. Will try smarter instead of harder from now on. |
|
TODO: Will need to move cube file to http://data.astropy.org server to make things work, as suggested in http://learn.astropy.org/contributing.html#data-files. Planning to do so next. |
Moving additional contents, including the data cube FITS file, to https://github.com/astropy/astropy-data/ via PR astropy/astropy-data#86. Will need to follow up soon before this PR can be finalized. |
Now am getting the expected 404 error. Will try to resolve this during one of the upcoming telecons soon. |
this needs a review from the @astropy/learn-astropy-maintainers team before I'm comfortable to merge the fits file into astropy-data |
@bsipocz Thanks for the notice! I will follow the matter up during one of the upcoming Learn Astropy telecons so that the maintainers will be aware of the situation and will review this PR accordingly. |
Add requirements.txt file for spectrumplot tutorial Downgrade Astropy version to pass CircleCI Add extra space to last line of file Update all versions of required packages to debug Update required pyspeckit version to dev version in notebook Debug Try in-notebook installation of regions to debug Remove kernel specs in notebook using GitHub interface Debug by changing path name for cubefile Change download file code Clean metadata Move extra files into astropy-data Debug notebook
I've reviewed approximately half of the notebook in detail. At this moment, it needs much more exposition and explanation of what is going to be done in the notebook and why. I've made a lot of notes for places were more explanatory material needs to be. However, I am concerned that several of the packages used in this tutorial are in the actively process of being replaced by specutils in some way. I recommend that we clean, perhaps rewrite, this tutorial during the Astropy spectroscopy sprint to make it as up-to-date with the Astropy ecosystem as possible. |
Sure, can do more exposition and explanation with a rewrite during Spectroscopy Sprint 2020 this week. |
@eblur I kind of get the idea of how you would like this tutorial to go, and will rewrite the tutorial significantly to match with your expectations. |
Fixes #331.
Adding new content to the Learn Astropy repo as the "Spectrum Plot" tutorial originally authored by Jeff Mangum. Original source can be accessed at: https://github.com/jmangum/spectrumplot. Consent has been obtained from Mangum to use his original material. This version is an expanded version of the original. Previously tested on Google Colab and the tutorial has been running successfully.