Skip to content
This repository has been archived by the owner on May 25, 2022. It is now read-only.

Remove ez_setup.py #384

Merged
merged 3 commits into from Mar 22, 2018
Merged

Remove ez_setup.py #384

merged 3 commits into from Mar 22, 2018

Conversation

astrofrog
Copy link
Member

As described in #297, ez_setup.py is deprecated. In fact, it's very rarely needed - these days virtually everyone has setuptools installed:

  • If a user does pip install ..., pip requires setuptools so setuptools will be present

  • If a user has conda and is doing e.g. python setup.py ..., conda environments automatically include setuptools.

  • Most other major scientific packages such as Numpy, Scipy, Pandas, etc. just assume setuptools is present.

I think this is safe to remove. Once it is removed here we can update astropy-helpers in the core package and remove it there too, as well as in the package template.

Now that setuptools 1.0 has been out for a while I think it's also safe to simply remove the logic related to 'distribute' and require setuptools 1.0 or later. For user-friendliness, I've made it so that a nice error message is printed rather than a traceback.

@astrofrog astrofrog requested review from eteq and bsipocz March 19, 2018 13:02
@astropy-bot
Copy link

astropy-bot bot commented Mar 19, 2018

Hi there @astrofrog 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@astrofrog astrofrog modified the milestone: v3.1.0 Mar 19, 2018
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all very sensible, thanks @astrofrog!

Copy link
Member

@eteq eteq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this all makes sense. Just a very minor typo in the changelog.

CHANGES.rst Outdated
@@ -6,6 +6,8 @@ astropy-helpers Changelog

- Removing deprecated test_helpers.py file. [#369]

- Removing ez_setup.py file and require setuptools 1.0 or later. [#384]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nitpick) to be grammatically correct I think this needs to be "requiring"? Or Removing->remove.

@astrofrog astrofrog merged commit 70543f1 into astropy:master Mar 22, 2018
@astrofrog astrofrog mentioned this pull request Mar 22, 2018
@bsipocz
Copy link
Member

bsipocz commented May 11, 2018

@astrofrog - So you suggest to backport this to LTS (astropy/package-template#315 (comment)), which is fine by me. But then we also need to backport to 3.0.x otherwise the changelog will become a mess. Would that be OK with you?

@astrofrog
Copy link
Member Author

Yes that sounds good, backporting to v2.0.x and v3.0.x seems like the right thing to do.

@astrofrog astrofrog modified the milestones: v3.1.0, v2.0.7 May 11, 2018
bsipocz pushed a commit that referenced this pull request May 16, 2018
bsipocz pushed a commit that referenced this pull request May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants