Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto deploy machinery #102

Merged
merged 5 commits into from
Dec 3, 2015
Merged

Auto deploy machinery #102

merged 5 commits into from
Dec 3, 2015

Conversation

eteq
Copy link
Member

@eteq eteq commented Dec 1, 2015

This should close #93 by finally setting it up so that merging a PR into master auto-deploys to github pages.

The main idea is that this modifys the deploy script to allow non-interactive use, as well as the @astropy-bot account as a user that has the appropriate access privileges along with a travis-encrypted access token.

The awkward thing is that we can't test it really until merging, as it's specifically not supposed to work until merged into master. If it helps any, though, you can see the results of this by looking at https://github.com/eteq/astropy-tutorials/tree/gh-pages, which was made by the build you see at https://travis-ci.org/eteq/astropy-tutorials/builds/94067132 . This should be basically the same, except with new tokens and such as relevant for the real astropy-tutorials repo. (Also, a bit more security that should completely hide the secret token).

cc @adrn @astrofrog

@adrn
Copy link
Member

adrn commented Dec 2, 2015

Nice! Thanks for this!

BTW: one thing that is probably unrelated to this PR that I just noticed -- the redshift plot tutorial .html file is missing a letter `edshift_plot.html'

@astrofrog
Copy link
Member

Very cool! No objections from me. One idea for testing before master would be to deploy to another branch if we're not on master, and then view it locally. For instance, you could push to a branch called <branch_name>-preview and then check that out locally if you want to see what it looks like?

@eteq
Copy link
Member Author

eteq commented Dec 2, 2015

@astrofrog - ah, clever idea, but it turns out that travis doesn't allow it. From https://docs.travis-ci.com/user/deployment/#Pull-Requests:

Note that pull request builds skip deployment step altogether.

What I can do is modify this to use a test branch, then we can merge it into master, check if it's working and if so, then modify it only to change to the real name. Will push up another commit that does that momentarily.

@eteq
Copy link
Member Author

eteq commented Dec 3, 2015

Alright, I'll merge this now and we'll see if it creates a test-gh-page branch that looks right. If it does, I can change it to the "real" gh-pages in master.

eteq added a commit that referenced this pull request Dec 3, 2015
@eteq eteq merged commit 13ecc5b into astropy:master Dec 3, 2015
@eteq eteq deleted the auto-deploy branch December 3, 2015 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis-based auto-deploy machinery
3 participants