Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release announcement/update for 3.1 #286

Merged
merged 10 commits into from Dec 11, 2018
Merged

Release announcement/update for 3.1 #286

merged 10 commits into from Dec 11, 2018

Conversation

eteq
Copy link
Member

@eteq eteq commented Dec 7, 2018

Just what it says on the tin... To be merged when the 3.1 builds are all done.

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart my comments below that we already discussed

announcements/release-3.1.html Outdated Show resolved Hide resolved
announcements/release-3.1.html Outdated Show resolved Hide resolved
announcements/release-3.1.html Outdated Show resolved Hide resolved
announcements/release-3.1.html Show resolved Hide resolved
announcements/release-3.1.html Show resolved Hide resolved
Copy link
Member

@adrn adrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is missing an update to the documentation dropdown menu on the main page -- see eteq#1

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<a href="http://docs.astropy.org/en/stable/whatsnew/3.1.html">http://docs.astropy.org/en/stable/whatsnew/3.1.html</a>
</p>
<p>
Note that the Astropy 3.x series only supports Python 3. Python 2 users can continue to use the 2.x series, which will receive bug fixes and support until the Python developers permanently sunset Python 2.7 (scheduled for 2019).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also emphasize that the 2.x series are not receiving new features?

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

<ul>
<li><a href="http://docs.astropy.org" target="_blank">Current Release</a></li>
<li><a href="http://devdocs.astropy.org/" target="_blank">In Development</a></li>
<li><a href="https://astropy.readthedocs.io/en/v1.2.2/index.html" target="_blank">v1.2.2</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eteq - it still has the full dropdown, please change it to the text only 3 options that was discussed in Adrian's PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I am still working on this, will push it up along with the other things shortly.

@eteq
Copy link
Member Author

eteq commented Dec 10, 2018

@adrn - maybe have a quick look at the updates I made to the dropdown and make sure you're 👍 ? (key point: turns out the dropdowns were mis-matched in a lot of places, but now they are better, since we don't have to worry about updating version numbers any more.)

Copy link
Member

@adrn adrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop-down looks ok, though eventually we should find a solution for the menu bar that doesn't involve copy-pasta!

But I have some new comments/suggestions:

announcements/release-3.1.html Outdated Show resolved Hide resolved
announcements/release-3.1.html Show resolved Hide resolved
announcements/release-3.1.html Outdated Show resolved Hide resolved
announcements/release-3.1.html Outdated Show resolved Hide resolved

</p>
<p>
If you use Astropy directly for your work, or as a dependency to another
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not copy and paste the acknowledgement from the acknowledging and citing page, or link to that?

@eteq
Copy link
Member Author

eteq commented Dec 11, 2018

Drop-down looks ok, though eventually we should find a solution for the menu bar that doesn't involve copy-pasta!

I agree in spirit, but it's hard to combine that with static web pages, unfortunately... I think this is why PHP was invented 😉. But maybe we can try at some point transitioning to hyde or some similar static site generator? If that's a direction to go, we should probably make an issue...

At any rate, I think I've updated this based on your comments, @adrn.

@eteq
Copy link
Member Author

eteq commented Dec 11, 2018

(oops, I screwed things up with a rebase/force push, one moment please)

these were originally on github but accidentally force-pushed away
@eteq eteq merged commit c7742c7 into astropy:master Dec 11, 2018
@eteq eteq deleted the release-3.1 branch December 11, 2018 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants