Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCDData doesn't support non-FITS WCS #11727

Open
astrofrog opened this issue May 11, 2021 · 2 comments
Open

CCDData doesn't support non-FITS WCS #11727

astrofrog opened this issue May 11, 2021 · 2 comments
Labels

Comments

@astrofrog
Copy link
Member

Currently CCDData seems to only accept FITS WCS:

if not isinstance(llwcs, WCS):
raise TypeError("the wcs must be a WCS instance.")

This seems overly restrictive, and it would be better to support any APE 14 WCS? If some specific methods don't support non-FITS WCS it might be better to disable those specific methods/features rather than not allow CCDData to be instantiated?

@astrofrog
Copy link
Member Author

This came up in spacetelescope/gwcs#362

@astrofrog
Copy link
Member Author

For instance it would be reasonable for to_hdu to raise an error if the WCS is not FITS WCS since it is a FITS-specific feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant