Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redshift Unit #11784

Closed
nstarman opened this issue May 24, 2021 · 3 comments · Fixed by #11786
Closed

Redshift Unit #11784

nstarman opened this issue May 24, 2021 · 3 comments · Fixed by #11786

Comments

@nstarman
Copy link
Member

Description

It's a dimensionless unit that useful for redshift-related equivalencies, like redshift-dimensionless, and cosmology-dependent conversions like redshift-temperature, redshift-distance.
From discussion with @mhvk and @adrn.

Would also be useful for cosmology calculations to return instead of a float.

@pllim pllim added the units label May 24, 2021
@adrn
Copy link
Member

adrn commented May 24, 2021

@pllim ?? Unless I do'nt understand RedshiftScaleFactor, I think the context is very different! We're talking about a new dimensionless unit meant to mark that a quantity is a special kind of dimensionless (i.e. a redshift), not a new class or functional form to compute a scale factor from a redshift.

@pllim
Copy link
Member

pllim commented May 24, 2021

Hmm, ok. But how will it work with our redshift model?

Cosmology, the Expansion automation moved this from Units & Equivalencies to Done Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants