Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up how erfa is imported in quantity_helper #11816

Closed
mhvk opened this issue Jun 6, 2021 · 1 comment
Closed

Clean up how erfa is imported in quantity_helper #11816

mhvk opened this issue Jun 6, 2021 · 1 comment
Labels
Refactoring units

Comments

@mhvk
Copy link
Contributor

mhvk commented Jun 6, 2021

Following on #11775 (comment), in quantity_helpers/erfa.py special care is taken to contruct a dict of helper functions even though erfa is a required dependency and those helpers are needed inside coordinates at least. So, one might as well just add to UFUNC_HELPERS directly. Or, if there is a need to try to keep memory use/import time short, to truly construct all helper functions only as needed
@mhvk mhvk mentioned this issue Jun 6, 2021
Merged
@mhvk
Copy link
Contributor Author

mhvk commented Aug 26, 2021

On second thought, I think there really is little need to change the module, so closing.

@mhvk mhvk closed this as completed Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactoring units
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@embray @mhvk