Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ASDF serialization support from this package (deprecated in v5.1) #11924

Closed
1 task
eslavich opened this issue Jul 6, 2021 · 3 comments · Fixed by #14668
Closed
1 task

Remove ASDF serialization support from this package (deprecated in v5.1) #11924

eslavich opened this issue Jul 6, 2021 · 3 comments · Fixed by #14668
Assignees
Labels
Refactoring 💤 io.misc.asdf Go to asdf-astropy repo
Milestone

Comments

@eslavich
Copy link
Contributor

eslavich commented Jul 6, 2021

Description

Over in https://github.com/astropy/asdf-astropy we are re-implementing astropy's ASDF support using the asdf package's new extension API. Once that package is finalized and released we can remove most ASDF-related code from astropy itself.

astropy.io.misc.asdf was deprecated in v5.1:

TODO:

  • Remove astropy/io/misc/asdf/ tree.
  • Remove remaining usage of astropy.io.misc.asdf in this package.
  • Remove astropy.io.misc.asdf docs.
  • Replace optional dependency asdf with asdf-astropy and set appropriate minversion for that.
  • Remove asdf from astropy/utils/compat/optional_deps.py, if possible.
  • Remove ignored asdf deprecation warnings in setup.cfg.
  • Update CI matrix accordingly.
  • Also address DOC: Replace asdf extension "legacy" doc with new way of doing things #11899
@eslavich eslavich added this to the v5.0 milestone Jul 6, 2021
@eslavich eslavich added the 💤 io.misc.asdf Go to asdf-astropy repo label Jul 6, 2021
@eslavich eslavich self-assigned this Jul 6, 2021
@pllim
Copy link
Member

pllim commented Jul 6, 2021

I think #11899 is a subset of this work.

@eslavich
Copy link
Contributor Author

eslavich commented Jul 6, 2021

I imagine we'll want to move most of that to asdf-astropy documentation and simply link there from here.

@pllim
Copy link
Member

pllim commented Oct 26, 2021

@eslavich , @nden et al. Is this really happening in 5.0? If not, please remove the milestone. Thanks!

@eslavich eslavich removed this from the v5.0 milestone Nov 3, 2021
@pllim pllim changed the title Remove ASDF serialization support from this package Remove ASDF serialization support from this package (deprecated in v5.1) Mar 8, 2022
@pllim pllim assigned WilliamJamieson and unassigned eslavich Mar 8, 2022
@pllim pllim added this to the v6.0 milestone Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactoring 💤 io.misc.asdf Go to asdf-astropy repo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants