Allow zero WCSAxes ticks

[dstansby]

Fixes #14159

Description

This pull request is to address ...

Fixes #

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label. Codestyle issues can be fixed by the bot.
• Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
• Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
• Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

[github-actions]

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

[dhomeier]

Thanks for the PR. There is a new failure with matplotlib dev, not introduced by these changes but probably rather an upstream change to TickLabels.draw() in 3.7.0dev, or perhaps rather to the underlying backend_agg.RendererAgg.draw() – wondering if you had any insights into that.

[dstansby]

🤷 - if you want to tag me in an issue for those new failures I might be able to take a look at them at some point.

[dhomeier]

🤷 - if you want to tag me in an issue for those new failures I might be able to take a look at them at some point.

#14174

[pllim]

CI should be green on main again. Please rebase. Thanks!

[astrofrog]

Looks like the hash is missing for Matplotlib 3.2.2?

[astrofrog]

I've updated the hash for 3.2.2 and rebased

[astrofrog]

Looks good to me know if the CI is happy!

[pllim]

I am not sure if this will backport cleanly because we bumped matplotlib minversion on main. Can we not backport?

[astrofrog]

I would like to backport

[pllim]

This now also needs a rebase. We dropped mpl311 and mpl322. It is mpl334 now.

[larrybradley]

@pllim I rebased and fixed the changelog.

[pllim]

There is a failure https://output.circle-artifacts.com/output/job/afb29499-538d-46b1-b9b3-974414264680/artifacts/0/results/fig_comparison.html

[pllim]

CircleCI failed with Baseline hash not found but can we ignore it?

[astrofrog]

@pllim - no the issue is that we are missing an update to the mpl334 file. If no one gets to it by later today I can try and fix that.

[pllim]

I don't know exactly what that means, so I'll leave it to you then; thanks, @astrofrog !

[dhomeier]

Some mismatches with the hashes:

__________________________ TestBasic.test_tick_angles __________________________
Hash 475f028bd48a51fe9dfc07fe3d58e63e629511fffeb3a4db27a26f6427b4256b doesn't match hash e828e41d48899dd706cc58bb6fb93427d30b4c16ccd360813b391a880bee692c in library /home/circleci/project/astropy/tests/figures/py39-test-image-mpl334-cov.json for test astropy.visualization.wcsaxes.tests.test_images.TestBasic.test_tick_angles.

Image comparison test
---------------------
The comparison to the baseline image succeeded.
__________________ TestBasic.test_tick_angles_non_square_axes __________________
Hash 3a3a15f71e7303368bd7cebb70c6fd1f9d6710edf8af2ceb68642c64c74492a2 doesn't match hash adc79cf700df608e662bd9b4904fd8160dce15e67d04698c04f650808411ea97 in library /home/circleci/project/astropy/tests/figures/py39-test-image-mpl334-cov.json for test astropy.visualization.wcsaxes.tests.test_images.TestBasic.test_tick_angles_non_square_axes.

Image comparison test
---------------------
The comparison to the baseline image succeeded.
___________________________ test_tickable_gridlines ____________________________
Hash 1be26963aaba221f9cd396aea0b9618e05ab8a49f8c02c0b4540041e91d06ce7 doesn't match hash ba289534a6a65f01d4dbe050bdcab5e97f19549339896dde84e3b861cd1b07ba in library /home/circleci/project/astropy/tests/figures/py39-test-image-mpl334-cov.json for test astropy.visualization.wcsaxes.tests.test_images.test_tickable_gridlines.

Image comparison test
---------------------
The comparison to the baseline image succeeded.
__________________ TestTransformCoordMeta.test_coords_overlay __________________
Hash f84074e12142676d17aca8e907065cf1eec4a55ea7d60ce7d7f22f456c09c24c doesn't match hash 673e604c362ea09ff027da86b5c7f39bf41469dc92143b382010144ab5779330 in library /home/circleci/project/astropy/tests/figures/py39-test-image-mpl334-cov.json for test astropy.visualization.wcsaxes.tests.test_transform_coord_meta.TestTransformCoordMeta.test_coords_overlay.

Image comparison test
---------------------
The comparison to the baseline image succeeded.
___________________ TestTransformCoordMeta.test_direct_init ____________________
Hash 99e84ea7ae80a9444c73d4fb9f24d707795149e1aeb18c3c1a7072bc3e134732 doesn't match hash 3d7c5f4e7a2e9025b9f05001cd41b24a3f3a09420adb5ea2241dd82188cccff2 in library /home/circleci/project/astropy/tests/figures/py39-test-image-mpl334-cov.json for test astropy.visualization.wcsaxes.tests.test_transform_coord_meta.TestTransformCoordMeta.test_direct_init.

[larrybradley]

I added the mpl hash and tests pass now.

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout v5.0.x
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 fb8d85481b87ffe10fb94bf7b8d55f35877dacec

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #14160: Allow zero WCSAxes ticks'

4. Push to a named branch:

git push YOURFORK v5.0.x:auto-backport-of-pr-14160-on-v5.0.x

5. Create a PR against branch v5.0.x, I would have named this PR:

"Backport PR #14160 on branch v5.0.x (Allow zero WCSAxes ticks)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout v5.2.x
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 fb8d85481b87ffe10fb94bf7b8d55f35877dacec

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #14160: Allow zero WCSAxes ticks'

4. Push to a named branch:

git push YOURFORK v5.2.x:auto-backport-of-pr-14160-on-v5.2.x

5. Create a PR against branch v5.2.x, I would have named this PR:

"Backport PR #14160 on branch v5.2.x (Allow zero WCSAxes ticks)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

[pllim]

Do we have to backport?