New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support masked where in ufuncs #14590
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhvk
added
utils
numpy-dev
API change
PRs and issues that change an existing API, possibly requiring a deprecation period
utils.masked
labels
Mar 27, 2023
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
This was referenced Mar 28, 2023
mhvk
force-pushed
the
masked-ufunc-where
branch
from
March 28, 2023 00:25
3a0540b
to
5e1cca7
Compare
byrdie
reviewed
Mar 28, 2023
byrdie
approved these changes
Mar 28, 2023
pllim
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API change
PRs and issues that change an existing API, possibly requiring a deprecation period
numpy-dev
utils.masked
utils
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to address the case where a
where
argument in a ufunc is masked. For this case, any masked elements will be masked in the output as well. This is not very useful in itself, but avoids problems in conditional functions (likenp.add(ma, 1, where=ma>10)
). It also meansnp.fix
will work also with numpy >= 1.25.Fixes #14571