Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support masked where in ufuncs #14590

Merged
merged 1 commit into from Mar 28, 2023
Merged

Support masked where in ufuncs #14590

merged 1 commit into from Mar 28, 2023

Conversation

mhvk
Copy link
Contributor

@mhvk mhvk commented Mar 27, 2023

This pull request is to address the case where a where argument in a ufunc is masked. For this case, any masked elements will be masked in the output as well. This is not very useful in itself, but avoids problems in conditional functions (like np.add(ma, 1, where=ma>10)). It also means np.fix will work also with numpy >= 1.25.

Fixes #14571

@mhvk mhvk added utils numpy-dev API change PRs and issues that change an existing API, possibly requiring a deprecation period utils.masked labels Mar 27, 2023
@mhvk mhvk added this to the v5.3 milestone Mar 27, 2023
@github-actions
Copy link

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@mhvk
Copy link
Contributor Author

mhvk commented Mar 28, 2023

@pllim - I think this is indeed ready to merge! Thanks, @byrdie, for the quick review.

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim pllim merged commit ddd0214 into astropy:main Mar 28, 2023
25 checks passed
@mhvk mhvk deleted the masked-ufunc-where branch March 28, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change PRs and issues that change an existing API, possibly requiring a deprecation period numpy-dev utils.masked utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: np.fix check fails with numpy-dev (TypeError: cannot write to unmasked output)
3 participants