Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: Remove deprecated imports from flrw #14672

Merged
merged 1 commit into from Apr 25, 2023
Merged

MNT: Remove deprecated imports from flrw #14672

merged 1 commit into from Apr 25, 2023

Conversation

pllim
Copy link
Member

@pllim pllim commented Apr 21, 2023

Description

This pull request is to fix #13071

@pllim pllim added this to the v6.0 milestone Apr 21, 2023
@pllim pllim requested a review from a team as a code owner April 21, 2023 20:55
@pllim pllim requested a review from nstarman April 21, 2023 20:55
@github-actions
Copy link

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim
Copy link
Member Author

pllim commented Apr 21, 2023

pre-commit.ci autofix

nstarman
nstarman approved these changes Apr 22, 2023
View reviewed changes
Copy link
Member

@nstarman nstarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Squash?

@pllim
MNT: Remove deprecated imports from flrw
544c680 
[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
@pllim
Copy link
Member Author

pllim commented Apr 24, 2023

Sure, squashed. Thanks!

nstarman
nstarman approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@nstarman nstarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pllim !

@nstarman
Copy link
Member

Are we good to merge v6.0?

@pllim pllim merged commit f7afd6c into astropy:main Apr 25, 2023
24 of 25 checks passed
@pllim pllim deleted the rm-deprecated-flrw branch April 25, 2023 13:44
@pllim
Copy link
Member Author

pllim commented Apr 25, 2023

Yes, branching has happened. Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nstarman nstarman nstarman approved these changes

Assignees
No one assigned
Labels
cosmology Refactoring
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.

Remove deprecated private cosmology.flrw variables
2 participants
@pllim @nstarman