Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: fitting fails when weights are passed and filter_non_finite=True #14695

Merged

Conversation

WilliamJamieson
Copy link
Contributor

@WilliamJamieson WilliamJamieson commented Apr 26, 2023

Description

When fitting, there is an option filter_non_finite which enables automatic filtering of non-finite values from the input data to a non-linear fitter. Currently, using this option (setting it as True) combined with passing fitting weights results in a ValueError when some items are filtered. This is because the weights passed have not being filtered, resulting in a shape mismatch.

This PR fixes this issue by also filtering the weights in the same way the input data is filtered. This is a follow-on fix for oversights in #13259

The problem is that the non-finite-filter is not applied to the weights,
when they are passed in. This results in a shape mismatch.
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner April 26, 2023 18:09
@github-actions
Copy link

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@WilliamJamieson WilliamJamieson added 💤 backport-v5.2.x on-merge: backport to v5.2.x 💤 backport-v5.3.x on-merge: backport to v5.3.x labels Apr 26, 2023
@WilliamJamieson WilliamJamieson added this to the v5.2.3 milestone Apr 26, 2023
@pllim pllim added the Bug label Apr 26, 2023
Copy link
Member

@perrygreenfield perrygreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson merged commit b3b8295 into astropy:main Apr 26, 2023
25 checks passed
@WilliamJamieson WilliamJamieson deleted the bugfix/non_finite_weights branch April 26, 2023 19:24
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Apr 26, 2023
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Apr 26, 2023
pllim added a commit that referenced this pull request Apr 26, 2023
…695-on-v5.2.x

Backport PR #14695 on branch v5.2.x (Bugfix: fitting fails when `weights` are passed and `filter_non_finite=True`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug modeling 💤 backport-v5.2.x on-merge: backport to v5.2.x 💤 backport-v5.3.x on-merge: backport to v5.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants