New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: fitting fails when weights
are passed and filter_non_finite=True
#14695
Merged
WilliamJamieson
merged 4 commits into
astropy:main
from
WilliamJamieson:bugfix/non_finite_weights
Apr 26, 2023
Merged
Bugfix: fitting fails when weights
are passed and filter_non_finite=True
#14695
WilliamJamieson
merged 4 commits into
astropy:main
from
WilliamJamieson:bugfix/non_finite_weights
Apr 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that the non-finite-filter is not applied to the weights, when they are passed in. This results in a shape mismatch.
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
WilliamJamieson
added
💤 backport-v5.2.x
on-merge: backport to v5.2.x
💤 backport-v5.3.x
on-merge: backport to v5.3.x
labels
Apr 26, 2023
perrygreenfield
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Apr 26, 2023
…assed and `filter_non_finite=True`
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Apr 26, 2023
…assed and `filter_non_finite=True`
pllim
added a commit
that referenced
this pull request
Apr 26, 2023
…695-on-v5.2.x Backport PR #14695 on branch v5.2.x (Bugfix: fitting fails when `weights` are passed and `filter_non_finite=True`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
modeling
💤 backport-v5.2.x
on-merge: backport to v5.2.x
💤 backport-v5.3.x
on-merge: backport to v5.3.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When fitting, there is an option
filter_non_finite
which enables automatic filtering of non-finite values from the input data to a non-linear fitter. Currently, using this option (setting it asTrue
) combined with passing fittingweights
results in aValueError
when some items are filtered. This is because theweights
passed have not being filtered, resulting in a shape mismatch.This PR fixes this issue by also filtering the
weights
in the same way the input data is filtered. This is a follow-on fix for oversights in #13259