Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow WCSAxes ticklabels to be rasterized #14760

Merged
merged 8 commits into from Sep 29, 2023

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented May 5, 2023

This refactors code in WCSAxes to allow ticklabels to be rasterized. This required modifying the signature of draw() so it can work with only renderer passed as an argument.

Using the example given in #12568, this improves the resulting plot from

grid-False-new

to
Screenshot 2023-05-05 at 19 25 50

Part 3/4 of #12672, and part of fixing #12568.

@github-actions
Copy link

github-actions bot commented May 5, 2023

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link

github-actions bot commented May 5, 2023

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@dstansby dstansby marked this pull request as ready for review May 6, 2023 12:27
@pllim pllim added this to the v6.0 milestone May 6, 2023
@pllim pllim added Bug API change PRs and issues that change an existing API, possibly requiring a deprecation period labels May 6, 2023
@dstansby
Copy link
Contributor Author

pre-commit.ci autofix

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@pllim pllim merged commit dac44e8 into astropy:main Sep 29, 2023
25 of 26 checks passed
@pllim
Copy link
Member

pllim commented Sep 29, 2023

Thanks!

@dstansby dstansby deleted the wcsaxes-ticklbl-draw branch September 30, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change PRs and issues that change an existing API, possibly requiring a deprecation period Bug visualization.wcsaxes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants