Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kwargs from WCSAxes.draw() #14772

Merged
merged 1 commit into from May 8, 2023

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented May 6, 2023

Matplotlib Axes do not take any kwargs anyway, so before this would error if a user passed them. I can't think of a good way to do a deprecation here, but since it would have errored before anyway I think it's safe to do this without a deprecation period?

Part of fixing #12672

@github-actions
Copy link

github-actions bot commented May 6, 2023

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link

github-actions bot commented May 6, 2023

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@dstansby dstansby marked this pull request as ready for review May 6, 2023 12:51
@pllim pllim added this to the v6.0 milestone May 6, 2023
@pllim pllim added the API change PRs and issues that change an existing API, possibly requiring a deprecation period label May 6, 2023
@pllim
Copy link
Member

pllim commented May 6, 2023

Thanks! Can you please squash all commits into one?

@dstansby
Copy link
Contributor Author

dstansby commented May 6, 2023

Can't whoever merges this choose the squash-and-merge option?

@pllim
Copy link
Member

pllim commented May 6, 2023

Not yet, see #14473

Add changelog

Remove args, kwargs from _WCSAxesArtist.draw()
@dstansby
Copy link
Contributor Author

dstansby commented May 8, 2023

👍 squashed

Copy link
Member

@larrybradley larrybradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears matplotlib.axes.Axes.draw didn't drop kwargs until mpl 3.5, but the other inframe keyword was deprecated going back until at least mpl 3.3. So, I think this is fine.

@larrybradley larrybradley merged commit 4898c2b into astropy:main May 8, 2023
24 of 25 checks passed
@dstansby dstansby deleted the wcsaxes-draw-kwargs branch May 8, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change PRs and issues that change an existing API, possibly requiring a deprecation period visualization.wcsaxes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants