New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove kwargs from WCSAxes.draw() #14772
Conversation
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
👋 Thank you for your draft pull request! Do you know that you can use |
Thanks! Can you please squash all commits into one? |
Can't whoever merges this choose the squash-and-merge option? |
Not yet, see #14473 |
Add changelog Remove args, kwargs from _WCSAxesArtist.draw()
d25d50f
to
7f9c788
Compare
👍 squashed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears matplotlib.axes.Axes.draw
didn't drop kwargs until mpl 3.5, but the other inframe
keyword was deprecated going back until at least mpl 3.3. So, I think this is fine.
Matplotlib Axes do not take any kwargs anyway, so before this would error if a user passed them. I can't think of a good way to do a deprecation here, but since it would have errored before anyway I think it's safe to do this without a deprecation period?
Part of fixing #12672