Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise nicer error message if factor is not integer #14794

Merged
merged 4 commits into from May 9, 2023
Merged

Raise nicer error message if factor is not integer #14794

merged 4 commits into from May 9, 2023

Conversation

larrybradley
Copy link
Member

Description

With this PR, discretize_model will now raise an informative ValueError if mode='oversample' and factor does not have an integer value.

@larrybradley larrybradley added convolution API change PRs and issues that change an existing API, possibly requiring a deprecation period labels May 8, 2023
@larrybradley larrybradley added this to the v6.0 milestone May 8, 2023
@github-actions
Copy link

github-actions bot commented May 8, 2023

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim
Copy link
Member

pllim commented May 8, 2023

Remote data passed here. Does this mean we no longer need #14789 ? 🤯

@larrybradley
Copy link
Member Author

Perhaps #14789 was just a glitch in the Matrix.

keflavich

This comment was marked as duplicate.

Sign in to view

keflavich
keflavich approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@keflavich keflavich left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, I just suggest including a reminder of the type requirement in the documentation too

astropy/convolution/utils.py Outdated Show resolved Hide resolved
@pllim pllim enabled auto-merge May 9, 2023 15:14
@pllim pllim merged commit eec0697 into astropy:main May 9, 2023
25 checks passed
@larrybradley larrybradley deleted the discretize-factor-int branch May 9, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keflavich keflavich keflavich approved these changes

Assignees
No one assigned
Labels
API change PRs and issues that change an existing API, possibly requiring a deprecation period convolution
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@larrybradley @pllim @keflavich