New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when a PrimaryHDU has a "GROUPS = 1" keyword #14998
Conversation
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
raise InvalidHDUException | ||
else: | ||
return False | ||
return card.keyword == "SIMPLE" and card.value is False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not strictly needed since _NonstandardHDU
comes after the other main extensions when finding the correct HDU class, but as the comment says this check is useless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the standard and this looks right, thanks!
This comment was marked as resolved.
This comment was marked as resolved.
…998-on-v5.3.x Backport PR #14998 on branch v5.3.x (Fix error when a PrimaryHDU has a "GROUPS = 1" keyword)
Manual backport of PR #14998 on branch v5.0.x
GROUPS = 1
was interpreted asGROUPS = T
which is wrong.This occurs on some Euclid commissioning file so I would like to make a bugfix release soon (with also the nddata fix).