Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated code and deprecate a few more things in io.fits #15396

Merged
merged 6 commits into from Oct 3, 2023
Merged

Remove deprecated code and deprecate a few more things in io.fits #15396

merged 6 commits into from Oct 3, 2023

Conversation

saimn
Copy link
Contributor

@saimn saimn commented Sep 27, 2023 •
edited

Description

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@saimn saimn added io.fits API change PRs and issues that change an existing API, possibly requiring a deprecation period labels Sep 27, 2023
@saimn saimn added this to the v6.0 milestone Sep 27, 2023
@github-actions
Copy link

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

mhvk
mhvk approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice to get rid of some old cruft.

pllim
pllim reviewed Sep 27, 2023
View reviewed changes
docs/changes/io.fits/15396.api.rst
Deprecate ``_ExtensionHDU`` and ``_NonstandardExtHDU`` (use ``ExtensionHDU`` or
``NonstandardExtHDU`` instead).

Remove special handling of TCTYP TCUNI TCRPX TCRVL TCDLT TRPOS (#7157)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Remove special handling of TCTYP TCUNI TCRPX TCRVL TCDLT TRPOS (#7157)
Remove special handling of TCTYP TCUNI TCRPX TCRVL TCDLT TRPOS (#7157).

@pllim
Copy link
Member

pllim commented Sep 27, 2023

You are very brave to deprecate/remove stuff in FITS...

astrofrog
astrofrog approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pllim pllim merged commit de782c5 into astropy:main Oct 3, 2023
26 checks passed
@pllim
Copy link
Member

pllim commented Oct 3, 2023

Thanks, all!

@saimn saimn deleted the fits-deprecation branch October 3, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim left review comments

@astrofrog astrofrog astrofrog approved these changes

@mhvk mhvk mhvk approved these changes

Assignees
No one assigned
Labels
API change PRs and issues that change an existing API, possibly requiring a deprecation period io.fits
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saimn @pllim @astrofrog @mhvk