Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: Removed deprecated version_path in minversion #15468

Merged
merged 1 commit into from Oct 12, 2023
Merged

MNT: Removed deprecated version_path in minversion #15468

merged 1 commit into from Oct 12, 2023
+2 −8

Conversation

pllim
Copy link
Member

@pllim pllim commented Oct 11, 2023

Description

This pull request is to address utils portion of #15455

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added the API change PRs and issues that change an existing API, possibly requiring a deprecation period label Oct 11, 2023
@pllim pllim added this to the v6.0 milestone Oct 11, 2023
@pllim pllim requested a review from saimn October 11, 2023 15:53
@github-actions github-actions bot added the utils label Oct 11, 2023
@github-actions
Copy link

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim mentioned this pull request Oct 11, 2023
Closed
10 tasks
eerovaher
eerovaher reviewed Oct 11, 2023
View reviewed changes
astropy/utils/introspection.py
Comment on lines -111 to -113
.. deprecated::
``version_path`` is not used anymore and is deprecated in
``astropy`` 5.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the docstring record that an argument was removed in 6.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot what is the policy if we use the .. deprecated:: directive like that. I think usually we remove all mention of it, except for the change log. @saimn , since you co-authored #11714 , any opinion here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I think we just remove this mention.

@pllim pllim merged commit dab1289 into astropy:main Oct 12, 2023
26 of 27 checks passed
@pllim pllim deleted the rm-depre-utils-v6.0 branch October 12, 2023 21:45
@pllim
Copy link
Member Author

pllim commented Oct 12, 2023

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eerovaher eerovaher eerovaher left review comments

@saimn saimn Awaiting requested review from saimn

Assignees
No one assigned
Labels
API change PRs and issues that change an existing API, possibly requiring a deprecation period utils
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pllim @saimn @eerovaher