Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure tables with masked and unmasked columns roundtrip properly #15473

Merged
merged 1 commit into from Oct 13, 2023
Merged

Ensure tables with masked and unmasked columns roundtrip properly #15473

merged 1 commit into from Oct 13, 2023

Conversation

mhvk
Copy link
Contributor

@mhvk mhvk commented Oct 12, 2023

Description

This pull request is to address that when a table was written to FITS and read back, all integer columns would become masked if any column in the table was masked.

Fixes #15417

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@mhvk mhvk added io.fits Bug 💤 backport-v5.0.x on-merge: backport to v5.0.x 💤 backport-v5.3.x on-merge: backport to v5.3.x labels Oct 12, 2023
@mhvk mhvk added this to the v5.0.9 milestone Oct 12, 2023
@mhvk mhvk requested a review from saimn as a code owner October 12, 2023 01:25
@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited by taldcroft

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@mhvk mhvk mentioned this pull request Oct 12, 2023
Closed
@mhvk mhvk requested a review from taldcroft October 12, 2023 19:24
taldcroft
taldcroft approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a FITS maintainer but this looks correct as far as I can tell. The change seems confined to the narrow context of the masking problem for int columns and the test demonstrates that the fix works.

@mhvk
Copy link
Contributor Author

mhvk commented Oct 13, 2023

Thanks for the review! I think this is trivial enough I can just merge (after all, I'm just correcting bugs in stuff I wrote...)

@mhvk mhvk merged commit 118af3d into astropy:main Oct 13, 2023
27 of 28 checks passed
@mhvk mhvk deleted the table-avoid-wrongly-masked-column branch October 13, 2023 19:12
@lumberbot-app

This comment was marked as resolved.

Sign in to view
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Oct 13, 2023
@mhvk @meeseeksmachine
Backport PR astropy#15473: Ensure tables with masked and unmasked col…
f965ba1 
…umns roundtrip properly
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 13, 2023
Merged
mhvk added a commit to mhvk/astropy that referenced this pull request Oct 13, 2023
@mhvk
Backport PR astropy#15473: Ensure tables with masked and unmasked col…
992d9b2 
…umns roundtrip properly
@pllim pllim mentioned this pull request Oct 13, 2023
Merged
pllim added a commit that referenced this pull request Oct 13, 2023
@pllim
Merge pull request #15480 from meeseeksmachine/auto-backport-of-pr-15…
a4000af 
…473-on-v5.3.x

Backport PR #15473 on branch v5.3.x (Ensure tables with masked and unmasked columns roundtrip properly)
pllim added a commit that referenced this pull request Oct 14, 2023
@pllim
Merge pull request #15481 from mhvk/auto-backport-of-pr-15473-on-v5.0.x
6288c85 
Backport PR #15473: Ensure tables with masked and unmasked columns roundtrip properly (v5.0.x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taldcroft taldcroft taldcroft approved these changes

@saimn saimn Awaiting requested review from saimn saimn is a code owner

Assignees
No one assigned
Labels
Bug io.fits 💤 backport-v5.0.x on-merge: backport to v5.0.x 💤 backport-v5.3.x on-merge: backport to v5.3.x
Projects
None yet
Milestone
v5.0.9
Development

Successfully merging this pull request may close these issues.

FITS int Column unexpectedly converted to MaskedColumn
2 participants
@mhvk @taldcroft