Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove io.ascii keyword arguments that were deprecated in v6.0 #15536

Closed
taldcroft opened this issue Oct 26, 2023 · 0 comments · Fixed by #15758
Closed

Remove io.ascii keyword arguments that were deprecated in v6.0 #15536

taldcroft opened this issue Oct 26, 2023 · 0 comments · Fixed by #15758
Labels
API change PRs and issues that change an existing API, possibly requiring a deprecation period Feature Request io.ascii
Milestone
v7.0.0

Comments

@taldcroft
Copy link
Member

taldcroft commented Oct 26, 2023 •
edited

What is the problem this feature will solve?

#14914 marked a number of keyword arguments as deprecated. In v7.0 these should be removed. This includes:

read():

  • Reader
  • Inputter
  • Outputter

get_reader():

  • Reader
  • Inputter
  • Outputter

write():

  • Writer

get_writer():

  • Writer

Describe the desired outcome

Providing those keywords will raise an exception instead of a DeprecationWarning.
@taldcroft taldcroft added this to the v7.0 milestone Oct 26, 2023
@pllim pllim added io.ascii API change PRs and issues that change an existing API, possibly requiring a deprecation period labels Oct 26, 2023
@taldcroft taldcroft mentioned this issue Oct 26, 2023
Merged
@MridulS MridulS mentioned this issue Dec 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API change PRs and issues that change an existing API, possibly requiring a deprecation period Feature Request io.ascii
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging a pull request may close this issue.

MAINT: Remove deprecated keywords args from io.ascii MridulS/astropy
2 participants
@taldcroft @pllim