Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support of custom WCS mapping. #15630

Merged
merged 4 commits into from Nov 24, 2023
Merged

Conversation

cmarmo
Copy link
Member

@cmarmo cmarmo commented Nov 18, 2023

Description

This pull request is to address issue #15625.
After the introduction of Solar System frames the creation of custom WCS frame with ctype yzLT, yzLN was no longer possible.
This pr reverts the previous behaviour.

Fixes #15625

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@cmarmo cmarmo requested a review from mcara as a code owner November 18, 2023 17:20
@github-actions github-actions bot added the wcs label Nov 18, 2023
Copy link

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim added this to the v6.1 milestone Nov 20, 2023
@pllim
Copy link
Member

pllim commented Nov 20, 2023

Thanks! Is this a bug or a new feature?

@cmarmo
Copy link
Member Author

cmarmo commented Nov 20, 2023

This is a fix for a regression introduced in #14820 ... I guess it would be nice to have it in 6.0 ... but then I don´t know how the Changelog should be managed...

@saimn
Copy link
Contributor

saimn commented Nov 20, 2023

@cmarmo - Please add a changelog entry with the usual way, it will then be backported with the PR.

@cmarmo
Copy link
Member Author

cmarmo commented Nov 20, 2023

... I have no clue about the failures...

@neutrinoceros
Copy link
Contributor

neutrinoceros commented Nov 21, 2023

@cmarmo I think failures are unrelated to your PR, just bad luck on timing. See pypa/setuptools#4126

@neutrinoceros
Copy link
Contributor

Turns out it's actually a simple fix away on our side: #15634

@svank
Copy link
Contributor

svank commented Nov 21, 2023

Can confirm this fixes #15625 for me. Thanks for the quick response, @cmarmo !

@cmarmo
Copy link
Member Author

cmarmo commented Nov 21, 2023

Thanks @neutrinoceros for pointing out the issue and for the follow-up leading to the fix!
I've triggered the CI, seems like everything is back to normal after pypa/setuptools#4127.

@saimn saimn modified the milestones: v6.1, v6.0 Nov 22, 2023
@saimn saimn added the backport-v6.0.x on-merge: backport to v6.0.x label Nov 22, 2023
@saimn saimn requested a review from nden November 22, 2023 18:06
@saimn
Copy link
Contributor

saimn commented Nov 22, 2023

@nden @mcara - If you have time to review, would be nice to get this in 6.0.

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to approve by proxy based on positive feedback from @svank but I will let others decide when to merge. Thanks!

@pllim pllim added the Bug label Nov 22, 2023
Copy link
Contributor

@mcara mcara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcara mcara merged commit 1aa3e6a into astropy:main Nov 24, 2023
33 of 34 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Nov 24, 2023
saimn added a commit that referenced this pull request Nov 24, 2023
…630-on-v6.0.x

Backport PR #15630 on branch v6.0.x (Fix support of custom WCS mapping.)
@cmarmo cmarmo deleted the custom-wcs-frames branch November 24, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v6.0.x on-merge: backport to v6.0.x Bug wcs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom WCS-frame mappings no longer supported?
6 participants