New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support of custom WCS mapping. #15630
Conversation
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Thanks! Is this a bug or a new feature? |
This is a fix for a regression introduced in #14820 ... I guess it would be nice to have it in 6.0 ... but then I don´t know how the Changelog should be managed... |
@cmarmo - Please add a changelog entry with the usual way, it will then be backported with the PR. |
a8ed505
to
3da88ab
Compare
... I have no clue about the failures... |
@cmarmo I think failures are unrelated to your PR, just bad luck on timing. See pypa/setuptools#4126 |
Turns out it's actually a simple fix away on our side: #15634 |
Thanks @neutrinoceros for pointing out the issue and for the follow-up leading to the fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to approve by proxy based on positive feedback from @svank but I will let others decide when to merge. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…630-on-v6.0.x Backport PR #15630 on branch v6.0.x (Fix support of custom WCS mapping.)
Description
This pull request is to address issue #15625.
After the introduction of Solar System frames the creation of custom WCS frame with ctype yzLT, yzLN was no longer possible.
This pr reverts the previous behaviour.
Fixes #15625