Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix a bug where LaTeX formatter would return empty strings for unity (1) input #15923

Merged
merged 2 commits into from Jan 23, 2024

Conversation

neutrinoceros
Copy link
Contributor

Description

This pull request is to address part of #12571

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions github-actions bot added the units label Jan 22, 2024
Copy link

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros changed the title BUG: fix a bug where latex formatter would return empty strings for unity (1) input BUG: fix a bug where LaTeX formatter would return empty strings for unity (1) input Jan 22, 2024
@neutrinoceros neutrinoceros marked this pull request as ready for review January 22, 2024 12:56
@pllim pllim added Bug 💤 backport-v6.0.x on-merge: backport to v6.0.x labels Jan 22, 2024
@pllim pllim added this to the v6.0.1 milestone Jan 22, 2024
@pllim pllim requested a review from mhvk January 22, 2024 20:52
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@mhvk mhvk merged commit 7759561 into astropy:main Jan 23, 2024
28 of 32 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Jan 23, 2024
@neutrinoceros neutrinoceros deleted the units/bugs/latex_one branch January 23, 2024 15:05
pllim added a commit that referenced this pull request Jan 23, 2024
…923-on-v6.0.x

Backport PR #15923 on branch v6.0.x (BUG: fix a bug where LaTeX formatter would return empty strings for unity (1) input)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug units 💤 backport-v6.0.x on-merge: backport to v6.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants