Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TDISP parsing for floating numbers #16007

Merged
merged 1 commit into from Feb 8, 2024
Merged

Conversation

saimn
Copy link
Contributor

@saimn saimn commented Feb 8, 2024

Fix #16006. (cc @orionlee)

Description

This pull request is to address ...

Fixes #

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@saimn saimn added the io.fits label Feb 8, 2024
@saimn saimn added this to the v6.0.1 milestone Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link
Contributor

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just about to post the same exact fix, well done !

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim pllim merged commit acccbcf into astropy:main Feb 8, 2024
30 of 31 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Feb 8, 2024
pllim added a commit that referenced this pull request Feb 8, 2024
…007-on-v6.0.x

Backport PR #16007 on branch v6.0.x (Fix TDISP parsing for floating numbers)
@orionlee
Copy link
Contributor

orionlee commented Feb 8, 2024

Format ES/ EN has the same problem. Should it be fixed in another PR, given this one is already merged?

TDISP_RE_DICT["EN"] = TDISP_RE_DICT["ES"] = re.compile(
r"(?:(?P<formatc>E[NS])(?:(?P<width>[0-9]+)\.{1}(?P<precision>[0-9])+)+)"
)

@pllim
Copy link
Member

pllim commented Feb 8, 2024

Yeah sorry if I merged it too fast. Please open a follow-up PR. Thanks!

@saimn saimn deleted the fits-fix-16006 branch February 8, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug io.fits 💤 backport-v6.0.x on-merge: backport to v6.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some FITS table columns are displayed incorrectly: float numbers shown as as integers
4 participants